[test] AudioWorklet tests now correctly run and exit #23695
Conversation
Step one of a fix for #23131 (the second part in #23695). Enabled Chrome's `FakeAudioOutputStream` for the CI machines and bypassed the need for user interaction. The Chrome tests are now enabled with `@requires_sound_hardware`. Many attempts at replicating the same functionally were tried with Firefox (details below) but audio would never run so its `EMTEST_LACKS_SOUND_HARDWARE` was left unchanged.
cwoffenden
force-pushed
the
cw-audio-test-must-run
branch
2 times, most recently
from
0b97ea5 to
fd8b9ba
Compare
|
@sbc100 Would you prefer all of the AW tests working/enabled in batches like this, or all as one? |
How many AW tests are there? If all of the tests are to be changes like this in the same manor I think doing it all at once seems reasonable. |
|
If you are asking about landing the fixes at the same time as the test updates, I think those are good to keep separate. I I like this this change simply updates test code, for example. |
sbc100
changed the title
|
Mostly just the small collection of AW tests in the same section of code, and they should follow the same pattern. I’ll combine them together. I’ll keep the test with the audio files and mixer part of the separate current PR (because it’s larger). And again separately I’ll add this to the browser tests but disabled, since it’s broken: And any fixes, e.g. wasm64 and 2gb in their own PRs. |
Test timed out on CI but runs locally.
We're also ensuring the test runs, not just silently exits.
cwoffenden
force-pushed
the
cw-audio-test-must-run
branch
from
1cd9f52 to
555ccd4
Compare
cwoffenden
changed the title
cwoffenden
changed the title
|
Is this change ready to land now? |
Yes, this change is all done (as is the mixer PR). |
2 participants
All the audio tests in
test_browser.py(except the mixer) were updated now the CI has audio, specifically:btest_exit()as previously discussedprintfcalls to Emscripten's API and not stdio)emscripten_force_exitreturning non-zero to verify they failed"Test success"and other outputs for tests withoutrequires_sound_hardwareThe mixer/AW struct test is a standalone PR in #23659.
Fixes: #23131